Add retry_time parameter instead of hardcoded 5 retries #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoncharov-reef
requested changes
Aug 3, 2023
agoncharov-reef
left a comment
agoncharov-reef
left a comment
There was a problem hiding this comment.
LGTM.
On b2-sdk side I would rather use timedelta type instead of int minutes, but it's out of scope of this review. Just a quick note.
Also, you're adding some parameter to CLI which should appear in low-level Download/Upload manager. I already wrote a test for it long time ago, I think you should add your retry-for parameter check there too. Please have a look at test_passing_api_parameters :)
|
I really think the resolution should be seconds, not minutes |
Author
|
I am changing to seconds. What could be the default retry time, 300 seconds? |
Author
|
I changed to seconds and added test to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry_time parameter to retry for some period (in minutes) when an upload or download fails, instead of hardcoded 5 retries
https://reeftechnologies.atlassian.net/browse/B2-3